ItsJustMe
Silver Member | Редактировать | Профиль | Сообщение | Цитировать | Сообщить модератору
I found a few suspicious lines in unrar's source:
filestr.cpp (25): if (FileName!=NULL && *FileName!=0) //why do we test a static array for NULL?
os.hpp (59): #if _MSC_VER<1500
#define for if (0) ; else for
#endif //What the hell is that?
strfn.cpp (286): void itoa(int64 n,char *Str) //can't we just use _i64toa_s/_i64tow_s?
unpack30.cpp (806): memcpy(UnpOldTable,Table,sizeof(UnpOldTable)); //Well, UnpOldTable is larger than Table. Should it be memcpy(UnpOldTable,Table,sizeof(Table));?
volume.cpp (244): CharToWide(NextNameA,NextName,ASIZE(NextName)); //Should it be CharToWide(NextNameA,NextName,NameSize);?
Sorry for disturbing you.
PS: Why don't you use CreateSymbolicLink for symlinks? |
